Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [IOBP-665,IOBP-570] PayPal metadata and latest used payment method adaption #5803

Merged
merged 6 commits into from
Jun 4, 2024
Merged

chore: [IOBP-665,IOBP-570] PayPal metadata and latest used payment method adaption #5803

merged 6 commits into from
Jun 4, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented May 29, 2024

Short description

This PR adds the metadata for fast PayPal payment by adding the masked email and the pspBusinessName if both are present. In addition, the selector has been adapted to handle the “recently used” logic by taking into account the lastUsage attribute of the clients map

List of changes proposed in this pull request

  • Upgraded the new openapi for wallet & ecommerce
  • Changed the selector to filter the "recently used" payment method following the new openapi definitions
  • Added metadata to the "Pagamento veloce con PayPal" with the pspBusinessName and maskedEmail if both present.

How to test

Preview

@Hantex9 Hantex9 added the IO-Bonus e pagamenti IO - Bonus e pagamenti label May 29, 2024
@Hantex9 Hantex9 requested review from thisisjp and a team as code owners May 29, 2024 14:10
@Hantex9 Hantex9 mentioned this pull request May 29, 2024
Merged
@pagopa-github-bot pagopa-github-bot changed the title feat: [IOBP-665,IOBP-570] PayPal metadata and latest used payment method adaption chore: [IOBP-665,IOBP-570] PayPal metadata and latest used payment method adaption May 29, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 29, 2024 •
edited by jira bot
Loading

Warnings
⚠️

Multiple stories with different types are associated with this Pull request.
Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • ⚙️ IOBP-665: Adattare il nuovo swagger prendendo in considerazione dell'attrbuto lastUsage
    subtask of
    • 🌟 IOBP-647: Pre-selezione ultimo metodo utilizzato
  • ⚙️ IOBP-570: Aggiunta metadati per “Pagamento veloce con Paypal” nella schermata selezione metodo
    subtask of
    • 🌟 IOBP-650: Visualizzazione metadati "Pagamento veloce con Paypal" in schermata selezione metodo

Generated by 🚫 dangerJS against 42efd9f

@codecov Codecov
Copy link

codecov bot commented May 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 49.75%. Comparing base (4f204b4) to head (9947a60).
Report is 122 commits behind head on master.

❗ Current head 9947a60 differs from pull request most recent head 42efd9f

Please upload reports for the commit 42efd9f to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5803      +/-   ##
==========================================
+ Coverage   48.42%   49.75%   +1.32%     
==========================================
  Files        1488     1632     +144     
  Lines       31617    32475     +858     
  Branches     7669     7926     +257     
==========================================
+ Hits        15311    16157     +846     
- Misses      16238    16256      +18     
+ Partials       68       62       -6
Files Coverage Δ
...checkout/components/CheckoutPaymentMethodsList.tsx 5.00% <0.00%> (ø)
...features/payments/checkout/store/reducers/index.ts 13.41% <0.00%> (-2.30%) ⬇️
...ayments/checkout/store/selectors/paymentMethods.ts 21.27% <0.00%> (ø)

... and 571 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f254f...42efd9f. Read the comment docs.

@Hantex9 Hantex9 requested a review from mastro993 June 4, 2024 07:40
@Hantex9 Hantex9 merged commit 5d017f9 into master Jun 4, 2024
11 checks passed
@Hantex9 Hantex9 deleted the IOBP-665-last-usage-openapi-adaption branch June 4, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastro993 mastro993 mastro993 approved these changes

@thisisjp thisisjp Awaiting requested review from thisisjp thisisjp is a code owner

Assignees
No one assigned
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hantex9 @pagopa-github-bot @mastro993